Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI job to check if updateBinary downloads the correct release #659

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

r0qs
Copy link
Member

@r0qs r0qs commented Sep 17, 2022

This PR addresses the comments made here #648 (comment) and is part of the solution for the issue #632.
It adds a CI job to test if the current version is equal to the downloaded release when using the updateBinary command.

@coveralls
Copy link

coveralls commented Sep 18, 2022

Coverage Status

Coverage: 84.537%. Remained the same when pulling 1283652 on test-download-latest-version-ci into c572d36 on master.

.circleci/config.yml Outdated Show resolved Hide resolved
scripts/update-and-check-binary.sh Outdated Show resolved Hide resolved
scripts/update-and-check-binary.sh Outdated Show resolved Hide resolved
scripts/update-and-check-binary.sh Outdated Show resolved Hide resolved
scripts/update-and-check-binary.sh Outdated Show resolved Hide resolved
scripts/update-and-check-binary.sh Outdated Show resolved Hide resolved
scripts/update-and-check-binary.sh Outdated Show resolved Hide resolved
scripts/update-and-check-binary.sh Outdated Show resolved Hide resolved
scripts/update-and-check-binary.sh Outdated Show resolved Hide resolved
scripts/update-and-check-binary.sh Outdated Show resolved Hide resolved
Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more minor tweaks but the overall direction of the PR is good.

scripts/check-binary.sh Outdated Show resolved Hide resolved
scripts/check-binary.sh Outdated Show resolved Hide resolved
scripts/check-binary.sh Outdated Show resolved Hide resolved
scripts/check-binary.sh Outdated Show resolved Hide resolved
scripts/check-binary.sh Outdated Show resolved Hide resolved
scripts/check-binary.sh Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
scripts/check-binary.sh Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still #659 (comment) left to resolve but this is not a major issue so I'm already approving. Fine to merge whether you decide to go with my suggestion there or not.

scripts/is-binary-up-to-date.sh Outdated Show resolved Hide resolved
@cameel
Copy link
Member

cameel commented Oct 6, 2022

Before merging please squash the commits a bit. Does not have to be just one but in this case this seems like the best option.It all looks like review fixes and we usually squash those into the original commits they change.

@r0qs r0qs force-pushed the test-download-latest-version-ci branch 2 times, most recently from 2b11884 to b18711d Compare October 23, 2022 21:47
@r0qs r0qs force-pushed the test-download-latest-version-ci branch from 6e17949 to aca5193 Compare October 31, 2022 17:52
@r0qs r0qs requested a review from cameel October 31, 2022 17:52
@r0qs r0qs self-assigned this Mar 20, 2023
Co-authored-by: Kamil Śliwak <kamil.sliwak@codepoets.it>
@r0qs r0qs force-pushed the test-download-latest-version-ci branch from aca5193 to 1283652 Compare March 20, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants